Use absolute instead of relative imports #809
Conversation
ansibullbot
added
community_review
module
There was a problem hiding this comment.
I'm generally good with this change. However, we should probably update the guidelines if we're going to do this. (docs/docsite/rst/dev_guidelines.rst) @nerijus If you're willing to add something that would be good, otherwise we can follow up afterwards as a house-keeping item.
@jillr @alinabuzachis - Any comments from the Cloud Content team side of things?
@markuman @marknet15 - As active community members any thoughts?
Do we want to put this on hold until the next meeting?
|
I generally prefer absolute imports anyway so this looks all good to me 👍 |
I will better leave updating guidelines to somebody else :) |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
) [3.0.0] Bump minimal botocore version to 1.19.0 SUMMARY In preparation for release 3.0.0, bump the minimal botocore version ISSUE TYPE Feature Pull Request COMPONENT NAME README.md plugins/modules/aws_s3_bucket_info.py requirements.txt tests/integration/constraints.txt tests/integration/targets/setup_botocore_pip/defaults/main.yml tests/unit/constraints.txt ADDITIONAL INFORMATION Depends-On: ansible-collections#574 Reviewed-by: None <None>
) [3.0.0] Bump minimal botocore version to 1.19.0 SUMMARY In preparation for release 3.0.0, bump the minimal botocore version ISSUE TYPE Feature Pull Request COMPONENT NAME README.md plugins/modules/aws_s3_bucket_info.py requirements.txt tests/integration/constraints.txt tests/integration/targets/setup_botocore_pip/defaults/main.yml tests/unit/constraints.txt ADDITIONAL INFORMATION Depends-On: ansible-collections#574 Reviewed-by: None <None>
) [3.0.0] Bump minimal botocore version to 1.19.0 SUMMARY In preparation for release 3.0.0, bump the minimal botocore version ISSUE TYPE Feature Pull Request COMPONENT NAME README.md plugins/modules/aws_s3_bucket_info.py requirements.txt tests/integration/constraints.txt tests/integration/targets/setup_botocore_pip/defaults/main.yml tests/unit/constraints.txt ADDITIONAL INFORMATION Depends-On: ansible-collections#574 Reviewed-by: None <None>
Although Ansible without mitogen works without this PR it is not possible to use it with Mitogen. This is similar to ansible-collections/amazon.aws#809 Signed-off-by: Wilfried Roset <[email protected]>
This fixes mitogen-hq/mitogen#896. Although ansible without mitogen works without this PR, please consider accepting this PR, because some other files already have absolute imports, for example,
ec2_instance.py,ec2_vpc_endpoint.py, etc.